Skip to content

Report: say what each target does — function description, UniProt Function text, GO by aspect (#107, part A) - #108

Merged
Jiahuic merged 3 commits into
mainfrom
report/function-description
Nov 15, 2026
Merged

Jiahuic merged 3 commits into
mainfrom
report/function-description

Conversation

@Jiahuic

@Jiahuic Jiahuic commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Part A of #107. Part B (GO/KEGG enrichment, GSEA) stays open on the issue.

What changes

  • report.json: new proteins[].function — description + source, summary (UniProt free-text Function comment, with evidence), go grouped by aspect, ec, kegg_ko, cog_category, and status (annotated / none / not_run). Schema updated.
  • UniProt fetch now requests cc_function.
  • Full report: a Function column in the selected-targets table. A run without annotation shows not annotated in this run; a run where nothing was found shows no functional annotation found (pitfall M2: triage scoring and selection #12).
  • Docs: 02c-m2-functional-annotation.md Outputs table.

Not changed

  • Scoring and selection: descriptive only, ranking identical.
  • GO from eggNOG/InterProScan has no aspect without an ontology file → listed as unclassified. GO slim grouping is a follow-up.

Tests

422 pass (2 new in test_m2_function.py, 2 in test_full_report.py).

🤖 Generated with Claude Code

…ction text, GO by aspect (#107)

M2 already merged a function description and GO/EC/KO terms, but nothing
downstream read them. report.json now carries proteins[].function, and the
full report shows it as a column of the selected-targets table.

- UniProt: request cc_function and keep the Function comment as summary,
  ranked like the description, experimental evidence kept apart.
- report_adapter.function_section: description, summary, GO grouped by
  aspect (UniProt names carry it; eggNOG/InterPro IDs are 'unclassified'),
  EC, KO, COG category, and status annotated / none / not_run.
- schema: _FUNCTION, status is an enum.
- full report: Function column; 'not annotated in this run' vs
  'no functional annotation found'.

Descriptive only; the score is unchanged. Part B of #107 (enrichment) is
not in this PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jiahuic and others added 2 commits November 14, 2026 21:20
Conflict in tests/test_m2_function.py: both sides appended tests (#107 and #72); kept both.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@Jiahuic
Jiahuic merged commit ad5f5a3 into main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant