Added secrets-manager module#41
Draft
uzairharoon20 wants to merge 2 commits into
Draft
Conversation
nhs-oliverslater
requested changes
May 29, 2026
| # Use the auto-generated context ID as the secret name. | ||
| # The caller controls the name by setting context labels: | ||
| # service, environment, stack, name, etc. | ||
| secret_name = module.this.id |
Contributor
There was a problem hiding this comment.
No point having a local that is just a literal of another value. Can you make this a conditional on if a user has passed in a var.secret_name (will also need a new variable to go with it)?
Suggested change
| secret_name = module.this.id | |
| secret_name = var.secret_name != null ? var.secret_name : module.this.id |
| type = string | ||
| default = null | ||
| sensitive = true | ||
| description = "The secret value to store as a plaintext string. Use jsonencode() to store structured data such as database credentials. Mutually exclusive with secret_string_wo." |
| variable "recovery_window_in_days" { | ||
| type = number | ||
| default = 30 | ||
| description = "Number of days AWS Secrets Manager waits before permanently deleting the secret. Valid values: 0 (immediate deletion) or 7-30." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.