Skip to content

intro IAM module#25

Closed
Pira-nhs wants to merge 20 commits into
mainfrom
feature/BCSS-23301-add-new-iam-module
Closed

intro IAM module#25
Pira-nhs wants to merge 20 commits into
mainfrom
feature/BCSS-23301-add-new-iam-module

Conversation

@Pira-nhs
Copy link
Copy Markdown
Collaborator

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

nhs-oliverslater and others added 16 commits May 6, 2026 12:30
…updated labelling and naming convention within module

BREAKING CHANGE: This changes the tag and naming output format to be able to be utilised by other modules. This will change resource naming and may result in resource re-creation.
…order

Update described defaults to reflect main.tf - Defaults to ["service", "project", "environment", "stack", "name", "attributes"]
…ed tag 'public_facing' to string

Generated tags uses length() which expects all tags_context to be a string, a collection type, or a structural type. var.public_facing is a bool, so have wrapped this in a tostring().
@Pira-nhs Pira-nhs force-pushed the feature/BCSS-23301-add-new-iam-module branch from e1071a4 to c3ebff9 Compare May 13, 2026 09:27
@nhs-oliverslater nhs-oliverslater marked this pull request as draft May 27, 2026 20:33
@nhs-oliverslater
Copy link
Copy Markdown
Contributor

Superseded by #39

@nhs-oliverslater nhs-oliverslater deleted the feature/BCSS-23301-add-new-iam-module branch May 27, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants