Skip to content

CCM-20515: switched client-provided URI placeholders to use curly brackets#1087

Open
cgitim wants to merge 6 commits into
releasefrom
feature/CCM-20515-bracket-fix
Open

CCM-20515: switched client-provided URI placeholders to use curly brackets#1087
cgitim wants to merge 6 commits into
releasefrom
feature/CCM-20515-bracket-fix

Conversation

@cgitim

@cgitim cgitim commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

The use of angle brackets (< and >) in placeholders for client-provided callback endpoint URIs has caused problems with the pages for those endpoints and links to them which are embedded in markdown.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

Comment thread specification/documentation/APIDescription.md Outdated
("personalisation", None),
("/<client-provided-message-status-URI>", None),
("/<client-provided-channel-status-URI>", None),
("/{client-provided-message-status-URI}", None),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At of curiosity, why has this section been omitted from the scan?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's due to angle brackets?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently they were originally omitted from ZAP because callback URLs are not real scannable endpoints on this API.

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

Co-authored-by: Ian Hodges <ian.hodges1@nhs.net>
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants