fix(desktop): react to sustained delayed frames - #83
Open
rldyourmnd wants to merge 4 commits into
Open
rldyourmnd wants to merge 4 commits into
rldyourmnd wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Interactive clicks on a WAN desktop could wait behind a media queue even when every frame eventually received an acknowledgement. The native viewer input queue could also close the viewer when a fast burst filled its 128-entry bound.
The Amsterdam trace showed
8 Mbps, hundreds of delayed frame receipts, and input injection itself at 0 ms. A real 30-click tab burst must preserve every button event and ordering.Change
Validation
cargo test -p rds-desktop --lib --features x11— 77 passedcargo clippy -p rds-desktop --all-targets --features x11 -- -D warnings— passedrds-agent --features desktopand installed atomically; Herdr/Xorg/user manager were not restarted.input_events_dropped=0,input_pointer_coalesced=0, max queue depth 4. A real 30-click tab burst produced 60 semantic events with no sequence gaps.