fix(desktop): preserve timely goodput and independent control dispatch - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated loss-only reductions could collapse native desktop quality despite recent successful timely media goodput. Add a conservative selected-path delivery floor from two populated receipt windows, counting only fully acknowledged timely payload bytes. Keep real delivery/RTT/producer pressure, holds, silence, path changes and negotiated ceilings protective; expose the observed timely bytes/rate in normal metadata health.
This consolidates the validated managed control/decode dispatch correction from #78 and canceled-sync admission fixture correction from #80. It also repairs the real-clock cadence assumption exposed by #80 macOS CI with production cadence functions on an explicit clock. A combined Mac check exposed an independent v1 sync failure; its original log is retained, the negotiated fixture pair now uses loopback with discovery disabled, and failures report both peer reasons. No accepted transfer is retried.
Validation: desktop unit tests 81 passed with no failures/ignores; strict full-workspace/all-target/all-feature Mac Clippy and formatting passed. Combined Mac suites passed 236 tests with 0 failures and one explicit OpenSSH ignore before the final pacing increment; its affected desktop suite and strict lint passed. The initial Linux candidate also finished tests, strict lint and optimized build; its SSH observer reset, so completed log receipts were checked independently. Final immutable candidate Linux qualification and builds are running. Original negative results remain retained; docs/reports/rds-confirmed-goodput-20261002.md states the regression/measurement boundaries. Native physical latency, full-load quality and sustained stability remain open.
Supersedes #78 and #80 after this consolidated implementation and all required checks are qualified.
A bounded independent key (at most 64 KiB, no outstanding media receipts) starts without an extra application pacing delay. QUIC pacing and the key capture barrier remain; debt, larger keys and nonempty/dependent traffic keep their bounds. Explicit output/clock tests cover the 500 ms prior wait and all admission guards. Normal logs now expose pacing waits.
Completed receipts are also retired after an idle producer wait, before deciding whether the next key has an empty media queue. A completed-JoinSet regression checks that the key can start immediately without another IDR or false failure. Final Mac optimized client build and strict lint passed; Linux durable qualification is running on exact source 5f2c1f2.