test(agent): wait for local admission after transfer cancellation - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cancellation fixture incorrectly treated a remote QUIC stream RESET as a fence for the independent local manager worker's admission-permit cleanup. Ubuntu CI observed a legitimate non-admitted
TransferBusyresponse before that cleanup completed.The fixture now requires local readmission within three seconds, polling only
TransferBusyrefusals. It never retries an accepted transfer or another error. Both transfer directions/backends, the initial Busy assertion, exact replacement file bytes and continued TCP/session use remain required. Runtime and wire code are unchanged; the documented asynchronous boundary is explicit.Validation: all three managed-transfer tests passed on macOS; strict workspace/all-target/all-feature lint and formatting passed. All three tests also passed on Linux in both default and all-feature lanes. Original failure is retained in issue #72 and its exact CI job.
Closes #72.