Rename puzzle_image to image on results responses - #185
Open
puzzlerushse wants to merge 1 commit into
Open
Conversation
MyResultsResponseProvider and PlayerResultsResponseProvider were the only two API responses still calling this field puzzle_image - CompetitionDetailResponseProvider already maps the same underlying $puzzle->puzzleImage to image (already live in production), matching how manufacturer_name and pieces_count are already unprefixed in this same results response despite also being facts about the puzzle, not the result. puzzle_id and puzzle_name keep their prefix since they'd otherwise be ambiguous against this response's own time_id, but nothing else in the payload could be confused with "image", so it fits the existing no-prefix pattern rather than needing a new one. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MyResultsResponseProviderandPlayerResultsResponseProviderwere the only two API responses still calling this fieldpuzzle_image—CompetitionDetailResponseProvideralready maps the same underlying$puzzle->puzzleImagetoimage(live in production today), matching howmanufacturer_nameandpieces_countare already unprefixed in this same results response despite also being facts about the puzzle, not the result.puzzle_idandpuzzle_namekeep their prefix since they'd otherwise be ambiguous against this response's owntime_id, but nothing else in the payload could be confused with "image", so this fits the existing no-prefix pattern rather than introducing a new one.Test plan
GET /api/v1/me/resultsandGET /api/v1/players/{id}/resultsnow returnimageinstead ofpuzzle_image