Repository navigation
[CLEANUP] Use number_format() in Size::render() - #1657
Merged
Merged
Conversation
This avoids the code having to be locale-aware, but doesn't simplify it much since `number_format()` has limited functionality. Also add additional test for a very small number, and a note that there seems to be a PHP bug in which the behaviour of `number_format()` is affected by the locale setting on some systems, even though it should not be. Closes #1653.
JakeQZ
added
cleanup
refactor
|
coverage: 75.43% (+0.001%) from 75.429% — cleanup/size-render into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the code having to be locale-aware, but doesn't simplify it much since
number_format()has limited functionality.Also add additional test for a very small number, and a note that there seems to be a PHP bug in which the behaviour of
number_format()is affected by the locale setting on some systems, even though it should not be.Closes #1653.