Skip to content

[TASK] Add tests for Size::render() - #1656

Merged
oliverklee merged 1 commit into
mainfrom
test/size-render
Oct 21, 2026
Merged

oliverklee merged 1 commit into
mainfrom
test/size-render

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator
  • Add extreme input cases that were pre-existing in ParserTest
  • Add note that there is a potential FPU precision testing environment issue
  • Test with locale that has , as decimal point
  • Rename some test methods accordingly

Part of #1653.

@JakeQZ
JakeQZ requested a review from oliverklee October 19, 2026 00:42
@JakeQZ JakeQZ self-assigned this Oct 19, 2026
@JakeQZ JakeQZ added the developer-specific Issues that only affect maintainers, contributors, and people submitting PRs label Oct 19, 2026
@coveralls

coveralls commented Oct 19, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 75.429%. remained the same — test/size-render into main

- Add extreme input cases that were pre-existing in `ParserTest`
- Add note that there is a potential FPU precision testing environment issue
- Test with locale that has `,` as decimal point
- Rename some test methods accordingly

Part of #1653.
@oliverklee
oliverklee merged commit 2ad5a95 into main Oct 21, 2026
26 checks passed
@oliverklee
oliverklee deleted the test/size-render branch October 21, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-specific Issues that only affect maintainers, contributors, and people submitting PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants