Skip to content

[CLEANUP] Move Size::render() tests to Functional - #1655

Merged
oliverklee merged 1 commit into
mainfrom
cleanup/tests/size
Oct 18, 2026
Merged

oliverklee merged 1 commit into
mainfrom
cleanup/tests/size

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

The methods have been renamed in anticipation for them also catering for large and other numbers (for #1653), and the unit has been removed from the string representation given by the data provider, to be handled internally by the test.

Closes #1654.

@JakeQZ
JakeQZ requested a review from oliverklee October 18, 2026 18:37
@JakeQZ JakeQZ self-assigned this Oct 18, 2026
@JakeQZ JakeQZ added cleanup testing PRs/issues adding additional tests only, or primarily testing-focused developer-specific Issues that only affect maintainers, contributors, and people submitting PRs refactor For PRs that refactor code without changing functionality labels Oct 18, 2026
@coveralls

coveralls commented Oct 18, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 75.429%. remained the same — cleanup/tests/size into main

@JakeQZ
JakeQZ force-pushed the cleanup/tests/size branch from a38c39c to ce9ce31 Compare October 18, 2026 18:42
The methods have been renamed in anticipation for them also catering for large
and other numbers (for #1653), and the unit has been removed from the string
representation given by the data provider, to be handled internally by the
test.

Closes #1654.
@JakeQZ
JakeQZ force-pushed the cleanup/tests/size branch from ce9ce31 to 24c0a26 Compare October 18, 2026 18:48

@oliverklee oliverklee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@oliverklee
oliverklee merged commit adb146d into main Oct 18, 2026
26 checks passed
@oliverklee
oliverklee deleted the cleanup/tests/size branch October 18, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup developer-specific Issues that only affect maintainers, contributors, and people submitting PRs refactor For PRs that refactor code without changing functionality testing PRs/issues adding additional tests only, or primarily testing-focused

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the tests for Size::render() from unit to functional tests

3 participants