[sean0407]

Problem

In a generic at-rule prelude, a quoted string containing { or ; was treated as a parser delimiter. For example, @media (custom: "a;b{c}") { ... } could end the prelude before its actual block and fail to preserve the following stylesheet rules. This addresses #1625.

Change

Scan quoted strings as part of the at-rule arguments, honoring escaped characters before continuing to look for the actual { or ; delimiter. Add a regression test that checks both the parsed at-rule arguments and the rule following the at-rule, and document the fix in the changelog.

Verification

Ran in an isolated PHP 8.5.11 container with no GitHub credentials; network was disconnected during test and static-analysis execution:

• PHPUnit: 3,031 tests and 4,188 assertions passed.
• PHP lint, Rector config and dry run, PHPCS, and PHPStan passed.
• PHP-CS-Fixer was not run because its configured .phive/php-cs-fixer executable is not present in this checkout.

Fixes #1625

[coveralls]

coverage: 75.429% (+0.1%) from 75.292% — sean0407:codex/fix-1625-at-rule-strings into MyIntervals:main

[JakeQZ]

Thanks @sean0407, this looks very good <3.

But I think we need additional testing for the backslash handling, and also suggest using regex for that to make it easier for the reader to follow. (It took me a while to work out what the loop was doing.)

[JakeQZ]

This is looking excellent now, though I think it would also be good to have a test with a backslash within an argument string but not at the end.

Also, by convention, we put the PR number in the changelog, and newer entries first.

(I was hitherto unaware that \z could be used in a regex as the equivalent of $.)

[JakeQZ]

LGTM now. Thanks @sean0407 for contributing <3.

@oliverklee, do you spot any issues, or is this good to go?

The changelog entry ordering can be adjusted post-PR. We normally only reference the PR number, but I don't see a reason not to reference the bug number as well.

[oliverklee]

Beautiful! Thank you for contributing this, @sean0407! ❤️