Skip to content

Update analyzer deps / setup #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LinusCenterstrom merged 4 commits into from
Jun 3, 2026
Merged

Update analyzer deps / setup #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa9c6cd
Update analyzer deps / setup
LinusCenterstrom May 22, 2026
44399e4
Removed redundant NoParam rule.
LinusCenterstrom May 22, 2026
feb426f
Fixed additional case the Analyzer was missing
LinusCenterstrom Jun 2, 2026
8e69dff
Remove beta tag
LinusCenterstrom Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MN.L10n.Analyzer/MN.L10n.Analyzer.Test/MN.L10n.Analyzer.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis" Version="4.13.0" />
<PackageReference Include="Microsoft.CodeAnalysis" Version="5.3.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
Expand Down
26 changes: 26 additions & 0 deletions MN.L10n.Analyzer/MN.L10n.Analyzer.Test/MNL10nAnalyzerUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,32 @@ Vänligen bekräfta ditt intresse genom att klicka på länken nedan.
VerifyCSharpDiagnostic(test, expectations.ToArray());
}

[Fact]
public void Test_MN0009_MissingKeywordsWhenArgumentIsNull()
{
var test = @"
namespace ConsoleApplication1
{
class TypeName
{
public void Main() {
_s(""Testing $someParameter$"", null);
}
}
}";

VerifyCSharpDiagnostic(test, new DiagnosticResult
{
Id = "MN0009",
Message = "L10n is missing '$someParameter$' in the object for keywords",
Severity = DiagnosticSeverity.Error,
Locations =
[
new DiagnosticResultLocation("Test0.cs", 7, 6)
]
});
}

protected override CodeFixProvider GetCSharpCodeFixProvider()
{
return new MNL10nCodeFixProvider();
Expand Down
72 changes: 0 additions & 72 deletions MN.L10n.Analyzer/MN.L10n.Analyzer.Vsix/MN.L10n.Analyzer.Vsix.csproj
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions MN.L10n.Analyzer/MN.L10n.Analyzer.Vsix/source.extension.vsixmanifest
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion MN.L10n.Analyzer/MN.L10n.Analyzer/AnalyzerReleases.Shipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

Rule ID | Category | Severity | Notes
--------|----------|----------|-------
MN0001 | L10n | Error | MNL10nAnalyzer
MN0002 | L10n | Error | MNL10nAnalyzer
MN0003 | L10n | Error | MNL10nAnalyzer
MN0004 | L10n | Error | MNL10nAnalyzer
Expand Down
30 changes: 15 additions & 15 deletions MN.L10n.Analyzer/MN.L10n.Analyzer/MN.L10n.Analyzer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeBuildOutput>false</IncludeBuildOutput>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<PublishSingleFile>true</PublishSingleFile>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<Nullable>enable</Nullable>
<LangVersion>latest</LangVersion>
<IsRoslynComponent>true</IsRoslynComponent>
<IncludeBuildOutput>false</IncludeBuildOutput>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -21,32 +24,29 @@
<Copyright></Copyright>
<PackageTags>MN.L10n.Analyzer, analyzers</PackageTags>
<NoPackageAnalysis>true</NoPackageAnalysis>
<Version>4.0.2</Version>
<Version>5.0.0</Version>
<Company>MultiNet Interactive AB</Company>
</PropertyGroup>

<PropertyGroup>
<PlatformTarget>x64</PlatformTarget>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis" Version="4.13.0" />
<PackageReference Update="NETStandard.Library" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.3.0" PrivateAssets="all" />
</ItemGroup>

<ItemGroup>
<Compile Update="Resources.Designer.cs" DesignTime="True" AutoGen="True" DependentUpon="Resources.resx" />
<EmbeddedResource Update="Resources.resx" Generator="ResXFileCodeGenerator" LastGenOutput="Resources.Designer.cs" />
</ItemGroup>

<ItemGroup>
<None Update="tools\*.ps1" CopyToOutputDirectory="Always" Pack="true" PackagePath="" />
<None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
</ItemGroup>

<ItemGroup>
<AdditionalFiles Include="AnalyzerReleases.Shipped.md" />
<AdditionalFiles Include="AnalyzerReleases.Unshipped.md" />
</ItemGroup>


<ItemGroup>
<None Update="tools\*.ps1" CopyToOutputDirectory="Always" Pack="true" PackagePath="" />
<None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
</ItemGroup>
</Project>
Loading
Loading