Repository navigation
fix(schemas): check secret name length after trimming - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secret names are trimmed before storage, but the 120 character limit was checked on the untrimmed input. A name with surrounding spaces whose trimmed form is exactly 120 characters was rejected, even though the stored value would have been within the limit. This change strips the name in a before validator for both SecretCreate and SecretUpdate so length is checked on the value that will actually be stored, while names over the limit after trimming are still rejected. A regression test covers both cases for both schemas.
Local test evidence: full pytest suite run locally with a SQLite test database, 38 passed (37 after the previous change plus 1 new test).