Repository navigation
fix(security): return False for unrecognised password hashes - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify_password passed the stored hash straight to pwdlib, so a malformed or unrecognised stored hash raised UnknownHashError instead of returning False. In the login route that would turn a corrupted stored hash into a server error instead of a 401 Invalid credentials response. This change catches PwdlibError in verify_password and returns False, with a regression test covering a plain string, an empty string, and a malformed Argon2 string.
Local test evidence: full pytest suite run locally with a SQLite test database, 37 passed (36 after the previous change plus 1 new test).