Repository navigation
fix(crypto): wrap non UTF8 plaintext in the safe decrypt error - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decrypt_value only caught InvalidToken, so a valid Fernet token whose plaintext is not UTF8 raised a raw UnicodeDecodeError instead of the documented ValueError with the message Stored secret cannot be decrypted. Callers and the key rotation script rely on that contract. This change catches UnicodeDecodeError alongside InvalidToken and adds a regression test using a Fernet token that encrypts non UTF8 bytes.
Local test evidence: full pytest suite run locally with a SQLite test database, 36 passed (35 baseline plus 1 new test).