Skip to content

fix: stop legacy insert from storing the trailing semicolon in email - #19

Merged
MugdhoAI merged 1 commit into
mainfrom
fix/legacy-insert-semicolon
Nov 14, 2026
Merged

MugdhoAI merged 1 commit into
mainfrom
fix/legacy-insert-semicolon

Conversation

@MugdhoAI

Copy link
Copy Markdown
Owner

Bug: the legacy form insert 5 bob bob@example.com; stored the email as bob@example.com; because the percent s scans in parse_legacy_insert swallowed the statement terminator, so valid_suffix never saw it. Fix: scan the username and email with scansets that stop at whitespace or a semicolon, leaving the terminator for valid_suffix, which also keeps trailing garbage rejected. Tests added to tests/test_parser.c: the legacy semicolon regression, legacy insert without a terminator, lowercase insert and select forms, meta .help and .exit, null and empty input, zero and negative id rejection, empty field rejection, and the exact 32 character username and 255 character email limits with one over rejected. Local verification: make clean and make test passed with a clean build under the strict flags, running test_database, test_pager, test_parser, and test_shell.sh, all exiting 0, and a direct parser probe confirms the legacy email is now stored without the semicolon.

@MugdhoAI
MugdhoAI merged commit 35ed7f0 into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant