Repository navigation
fix: stop legacy insert from storing the trailing semicolon in email - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: the legacy form insert 5 bob bob@example.com; stored the email as bob@example.com; because the percent s scans in parse_legacy_insert swallowed the statement terminator, so valid_suffix never saw it. Fix: scan the username and email with scansets that stop at whitespace or a semicolon, leaving the terminator for valid_suffix, which also keeps trailing garbage rejected. Tests added to tests/test_parser.c: the legacy semicolon regression, legacy insert without a terminator, lowercase insert and select forms, meta .help and .exit, null and empty input, zero and negative id rejection, empty field rejection, and the exact 32 character username and 255 character email limits with one over rejected. Local verification: make clean and make test passed with a clean build under the strict flags, running test_database, test_pager, test_parser, and test_shell.sh, all exiting 0, and a direct parser probe confirms the legacy email is now stored without the semicolon.