Repository navigation
test: cover pager page limits and flush validation - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing pager boundary tests to tests/test_pager.c: requesting page TABLE_MAX_PAGES and beyond returns PAGER_OUT_OF_PAGES while the last valid page succeeds, flushing an unallocated or out of range page and closing a null pager return PAGER_INVALID_ARGUMENT, null arguments to pager_open and pager_get_page are rejected, and a file with TABLE_MAX_PAGES plus one pages is rejected at open with PAGER_OUT_OF_PAGES. Local verification: make clean and make test passed with a clean build under the strict flags, running test_database, test_pager, test_parser, and test_shell.sh, all exiting 0.