Skip to content

26 q3.1 - #13

Open
MstfSlm38 wants to merge 8 commits into
26Q2.5from
26Q3.1
Open

26 q3.1#13
MstfSlm38 wants to merge 8 commits into
26Q2.5from
26Q3.1

Conversation

@MstfSlm38

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review


P2 Badge Define a test script before invoking npm test

In the new release workflow, the build job always runs npm test, but package.json only defines start, dist:win, dist:linux, and dist:all; running npm test in this checkout exits with Missing script: "test". As a result, every release.created run stops here and the dependent publish-npm job never publishes unless a real test script is added or this step is replaced/removed.


CodeSnip/main.js

Lines 92 to 95 in 3d04a5f

// Yüklenen dosyanın geçerli bir JSON olup olmadığını doğrula
JSON.parse(rawData);
return { success: true, data: rawData };

P2 Badge Validate backup shape before accepting imports

This only checks that the selected file is syntactically valid JSON, so a user can import package.json, {}, or any other JSON file and still get a success response. The renderer then stores that string as all_snippets_data, and on reload renderSnips() calls .forEach on the parsed value, which crashes for non-array data and can leave the app unusable until localStorage is manually cleared; validate that the JSON is the expected snippet array before returning success.


CodeSnip/renderer.js

Lines 761 to 766 in 3d04a5f

const localData = localStorage.getItem('all_snippets_data');
if (!localData || localData === '[]') {
alert(currentLang === 'tr' ? 'Yedeklenecek herhangi bir kod veya prompt bulunamadı!' : 'No snippets found to backup!');
return;
}
const result = await ipcRenderer.invoke('export-data', localData);

P2 Badge Include custom categories in backups

With the new category-management UI, custom categories are persisted separately under codesnip_categories, but export still serializes only all_snippets_data here. If a user backs up snippets in custom categories and restores on a clean install or after factory reset, import restores the snippets but renderCategories() recreates only defaults, so those categories disappear from navigation and the add/edit selector; include the category store in the backup format and restore it with the snippets.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant