Repository navigation
chore: extend sedg nono profiles and restore Azure DevOps SSH - #40
Merged
Merged
Conversation
Sandboxed agents on sedg projects need to pull images from the SolarEdge Docker registry and packages from the R&D Nexus instance.
The sedg Edge Metadata project is developed with both Python and Node.js, so give it a dedicated profile and launcher built from the shared sedg access and the personal language profiles. Python projects using Poetry need its config directory, so allow reading it in the personal Python profile.
Dropping RSA signing access also removed the sandbox's read access to id_rsa.pub. With IdentitiesOnly set for ssh.dev.azure.com, ssh needs that public key to pick the matching host ssh-agent key, so sedg agents could no longer fetch or push over SSH. Grant only the public RSA key in the common sedg profile and preload the RSA key into the host agent from the sedg Claude launchers. The private key stays unreadable inside the sandbox, and commit signing keeps using Ed25519. Tell maintainers to reuse an employer launcher file's own helper so new launchers keep such employer-specific setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Sandboxed agents on sedg projects lost SSH access to Azure DevOps when RSA signing was removed. That change also dropped the sandbox's read access to
id_rsa.pub, which ssh needs to pick the matching hostssh-agentkey. This PR restores that access without exposing the private key. It also adds the Docker and Nexus registries to the common sedg profile, and adds an Edge Metadata profile.Key Decisions
🔑 Azure DevOps SSH Authentication
~/.ssh/configsetsIdentitiesOnly yesandIdentityFile ~/.ssh/id_rsaforssh.dev.azure.com. In this setup, ssh reads the public key to choose which agent key to offer.work-sedg-commonnow grants onlyid_rsa.pub, through bothread_fileandbypass_protection. The private key stays denied bydeny_credentials. Commit signing still uses Ed25519.🚀 RSA Key Preload in sedg Launchers
The shared launcher now preloads only the Ed25519 key. The sedg Claude launchers call a new
_sedg_claude_nonowrapper. It loadsid_rsainto the hostssh-agentbefore it calls_claude_nono. Like the existing preload, this is best-effort and never blocks launch. Themanaging-nono-profilesskill now tells maintainers to reuse the helper that an employer launcher file already uses. That way, new sedg launchers keep this wrapper.🧩 Edge Metadata Profile
Edge Metadata uses both Python and Node.js. Its new profile extends
work-sedg-common,claude-code-python, andclaude-code-node, and it has a matching launcher.claude-code-pythoncan now read Poetry's config directory.🔄 Before & After
ssh-agentid_rsaprivate key in sandboxdocker-eshandseil-nexus-rndallowedwork-sedg-claude-code-edge-metadatawith launcher