Repository navigation
feat: add sandboxed Claude ACP support - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Claude ACP can now run through the same nono-managed profile flow as Codex and OpenCode.
The shared launcher is client-neutral and supports personal, project, and work profiles for all three runtimes.
This lets Zed and other ACP clients select the required sandbox profile without depending on client-specific paths.
Key Decisions
🔒 Sandboxed Claude ACP
Claude ACP starts through
npx @agentclientprotocol/claude-agent-acp@latestwith a dedicated cache under~/.claude. It delegates sandbox setup and SSH signing to the shared nono wrapper, matching the existing Codex ACP behavior without depending on Zed's managed adapter files.🔌 Client-Neutral Launcher
The shared executable is named
nono-agent-acpbecause its contract is the nono sandbox and ACP protocol, not a specific client. It routes each profile to Claude, Codex, or OpenCode and initializes Node only for the two externalnpxadapters.🧭 Work Profile Routing
The launcher accepts agent-specific work profile names in addition to personal and project profiles. This keeps employer-specific filesystem and network policy selection available to any ACP client.
🧹 Explicit Codex Helpers
Codex helper names now identify the nono wrapper and npm-cache behavior directly. This is a naming-only cleanup that makes the regular and ACP launch paths easier to distinguish.
🔄 Before & After
zed-agent-acpimplied one clientnono-agent-acpworks with any ACP client