Repository navigation
Python: define WorkoutState with the FIT intensity values. - #37
Open
sanderroosendaal wants to merge 4 commits into
Open
sanderroosendaal wants to merge 4 commits into
sanderroosendaal wants to merge 4 commits into
Conversation
Unknown values are read as Other. When a record disagrees with its lap intensity, the lap wins. Co-authored-by: Cursor <cursoragent@cursor.com>
JBlaak
requested changes
Oct 9, 2026
JBlaak
left a comment
JBlaak
left a comment
Member
There was a problem hiding this comment.
The reader now fills Lap.intensity, but write_fit never sets lap_msg.intensity, so it is lost on a round trip. §4.1 says producers MUST set intensity on every Lap they write. Could the writer write it (defaulting to active when unset, including on the single synthetic lap), with a round-trip test?
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Done in f4497c1: 🤖 Generated with Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown values are read as Other. When a record disagrees with its lap intensity, the lap wins.
Co-authored-by: Cursor cursoragent@cursor.com
Implements the Python side of #17. Should be merged after #17.
The diff against
maincontains only this change.🤖 Generated with Claude Code