Repository navigation
fix(env): commit MuJoCo model-field DR through host bridge - #2123
Merged
Merged
Conversation
Collaborator
Author
|
Remote CI on current head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
body_mass/body_comstill sample once, commit full-width through the publicSimBackend.set_state(..., randomization=...)boundary, and run before read-plan binding, the first reset, or a step. MuJoCo no longer attempts to commit startup DR before its public selected-reset/model pool exists.body_mass,body_com(body_ipos),geom_friction, or PD gains now compose into oneHostBridgeTransferPlan.apply_reset(..., randomization=...)call.TensorLifecycleCapabilities.reset_randomization; mapped scene patches remain unsupported on this boundary.User-facing impact: downstream manager-based MuJoCo tasks using the tensor command carrier / HOST_BRIDGE path no longer need to disable the issue's startup/reset model-field DR terms.
Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
Remote CI route:
main: current-head CI link and status recorded below after the run starts.Impact
mujoco(public HOST_BRIDGE lifecycle only; no backend-private access)Artifacts
Checklist
Follow-up: if a future backend needs to distinguish scalar
set_stateDR support from packed host-bridgeapply_resetDR support, add a dedicated public capability rather than probing backend internals.