Skip to content

test: improve coverage for matching package - #365

Merged
RoiSoleil merged 1 commit into
masterfrom
test/improve-coverage-matching-1991555873679649980
Aug 27, 2026
Merged

test: improve coverage for matching package#365
RoiSoleil merged 1 commit into
masterfrom
test/improve-coverage-matching-1991555873679649980

Conversation

@RoiSoleil

Copy link
Copy Markdown
Contributor

This patch introduces JUnit 5 tests for four utility/matching classes in the org.moreunit.core.matching package:

  • MatchSelection
  • MatchStrategy
  • MatchResult
  • FileMatchCollector

These tests adhere to the project constraints by using lightweight Mockito mocks and preventing any requirement for a full Eclipse OSGi workbench spin-up.

Tested classes: MatchSelection, MatchStrategy, MatchResult, FileMatchCollector
Newly covered branches: Edge conditions for FileMatchCollector matching depending on unresolved folders, multiple branch scenarios inside MatchResult when selecting files, enum instantiation in MatchStrategy, and null bounds logic inside MatchSelection.
Mocking choice rationale: Mockito was used to mock IFile and SourceFolderPath to avoid actual workspace filesystem access.


PR created automatically by Jules for task 1991555873679649980 started by @RoiSoleil

This patch introduces JUnit 5 tests for four utility/matching classes in the org.moreunit.core.matching package:
- MatchSelection
- MatchStrategy
- MatchResult
- FileMatchCollector

These tests adhere to the project constraints by using lightweight Mockito mocks and preventing any requirement for a full Eclipse OSGi workbench spin-up.

Tested classes: MatchSelection, MatchStrategy, MatchResult, FileMatchCollector
Newly covered branches: Edge conditions for FileMatchCollector matching depending on unresolved folders, multiple branch scenarios inside MatchResult when selecting files, enum instantiation in MatchStrategy, and null bounds logic inside MatchSelection.
Mocking choice rationale: Mockito was used to mock `IFile` and `SourceFolderPath` to avoid actual workspace filesystem access.

Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@RoiSoleil
RoiSoleil merged commit 8971ec3 into master Aug 27, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant