test(server): relax flaky startServer port-retry integration assertion#942
Closed
tomsen-ai wants to merge 1 commit into
Closed
test(server): relax flaky startServer port-retry integration assertion#942tomsen-ai wants to merge 1 commit into
tomsen-ai wants to merge 1 commit into
Conversation
The test assumed port+1 stays free between allocation and startServer binding. Under vitest concurrency another worker can grab it, causing startServer to bind to port+2 or higher. Relax the integration assertion to check the bound port is >= port+1 and that the lock file reflects the actual bound port. The exact +1/+2 retry sequence is already covered by unit tests for listenWithPortRetry. Closes MoonshotAI#937
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #937
Problem
See #937 for the full report.
packages/server/test/start.test.tshad a flaky assertion that assumedstartServerwould always bind to exactlyport + 1whenportwas occupied. Under vitest's concurrent workers, another test could grabport + 1in the window between allocation and binding, causingstartServerto advance toport + 2or higher and the strict equality check to fail.What changed
>= port + 1instead of requiring exactlyport + 1.status/kill/pswill work.The exact
+1 / +2 / ...retry strategy is still pinned by the existing unit tests forlistenWithPortRetry, which use a fake gateway and do not depend on real port allocation.Checklist