Skip to content

fix(acp): match toggleable models case-insensitively #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tt-a1i wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Draft

fix(acp): match toggleable models case-insensitively #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/acp-model-toggle-case.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@moonshot-ai/kimi-code": patch
---

Detect ACP toggleable thinking models case-insensitively.
2 changes: 1 addition & 1 deletion packages/acp-adapter/src/model-catalog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function deriveThinkingSupported(alias: ModelAlias): boolean {
if (declared.includes('thinking') || declared.includes('always_thinking')) return true;
const lower = alias.model.toLowerCase();
if (lower.includes('thinking') || lower.includes('reason')) return true;
if (TOGGLEABLE_THINKING_MODELS.has(alias.model)) return true;
if (TOGGLEABLE_THINKING_MODELS.has(lower)) return true;
return false;
}

Expand Down
5 changes: 5 additions & 0 deletions packages/acp-adapter/test/model-catalog.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ describe('deriveThinkingSupported', () => {
expect(deriveThinkingSupported(alias('some-thinking-model'))).toBe(true);
expect(deriveThinkingSupported(alias('plain-model'))).toBe(false);
});

it('matches toggleable model names case-insensitively', () => {
expect(deriveThinkingSupported(alias('Kimi-Code'))).toBe(true);
expect(deriveThinkingSupported(alias('Kimi-For-Coding'))).toBe(true);
});
});

describe('deriveAlwaysThinking', () => {
Expand Down