fix(agent-core-v2): revalidate file freshness when the scheduled write starts - #3165
Open
jangjoe wants to merge 1 commit into
Open
fix(agent-core-v2): revalidate file freshness when the scheduled write starts#3165jangjoe wants to merge 1 commit into
jangjoe wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 879b404 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Follow-up to #3096 — addresses the P1 review finding left unresolved there (Codex review on the stale-guard PR).
Problem
The Edit/Write staleness check ran during tool-call preparation, before the batch scheduler started any task. A file modified after that check — while the write waited behind a conflicting tool call or a user approval prompt — was overwritten without detection.
What changed
onExecuteToolordered hook to the agent-core-v2 tool executor that runs inside the scheduled task, directly around the physical tool execution (i.e. after conflicting predecessors have completed).'vetoed'when the file changed since the last read; mtime recording for Read/Edit/Write also moved into the task, so same-batch sequences (Read→Edit, consecutive writes) see the predecessor's record deterministically.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.