Repository navigation
feat(trade-window): allow maximizing the trade detail window - #1008
Merged
Merged
Conversation
The trade detail window opened from a Report row could only be resized by hand. It now carries the same Minimize, Maximize and Close controls as detached panels, double-click on its title toggles maximize, and the maximized state is restored on reopen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A user asked for a way to open a trade's chart from the Report full screen. The trade detail window (Report row -> trade window) was Close-only, so it could only be resized by hand.
It now carries the same Minimize / Maximize / Close set as detached panels (MoonUI has no Maximize+Close-only set), double-click on its title toggles maximize, and the maximized state is restored on reopen through the existing
GeomRect/window_bounds_forpath. The manual trading window stays Close-only.theme_contract::windowinganddocs/WINDOWING.mddescribe the new frame.How to verify
cargo test -p moon-ui-gpui --test theme_contract windowing,cargo test -p moon-ui-gpui --bin moonterminal trade_window. Checked on a live build: maximize fills the monitor with the chart, restore returns the previous size.