Repository navigation
feat(assets): convert a Binance core's dust to BNB from the Assets panel - #1006
Merged
Merged
Conversation
kirillDevPro
added a commit
that referenced
this pull request
Oct 18, 2026
What was stale: the locale "files by area" list named core_settings, which is no file (its keys live in shell.en.yml; the Core settings window reads core_expert), and left out assets, trade_window, station and the telegram files. The feature map had no entry for features merged since the doc was last touched: where a coin is blacklisted (#972), a Binance spot core's dust to BNB (#1006), Telegram reports by exchanges, cores or core groups (#1032), and the Mini App's live coin chart and closed-trade / open-position tick charts (#1009, #1016). What the code does now: checked against locales/en/, dust_target in panels/assets/dust.rs (Binance spot only), ReportView in config/telegram_menu.rs and the commits' own descriptions. Reviewer: Codex, no disputed claims.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The dust conversion command was wired from MoonProto down to the session API but had no caller. Assets now shows a per-core convert action for Binance Spot cores, with one confirmation (core, venue, BNB) before the existing
convert_dustcommand is sent; the existing notification reports the result.Gate/GT is not offered: the pinned MoonProto exposes only the BNB conversion.
How to verify
cargo test -p moon-ui-gpui --bin moonterminal panels::assets::dust.Fixes #658