Repository navigation
feat(strategies): forget the Deleted folder on every core of the window in one step - #1005
Merged
Merged
Conversation
…ow in one step Fixes #968
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Clearing deleted strategies took one right-click per core. The
Удалённыеfolder menu now also offers forgetting the deleted strategies of every core the Strategies window shows (collapsed and search-hidden cores included), with one confirmation naming the total and the core count.It reuses the existing per-core forget path: local erase of deleted rows and their version history only; live strategies and other groups' cores are untouched and nothing is sent to a core.
How to verify
cargo test -p moon-ui-gpui --bin moonterminal strategies::tree::menu,cargo test -p moon-core strat_db::write.Fixes #968