🐛 fix think-block cleanup truncating visible text - #3751
Open
ump45nose wants to merge 1 commit into
Open
Conversation
ump45nose
requested review from
Dallas98,
WMC001 and
jeffwu-1999
as code owners
August 23, 2026 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<think>...</think>pair before removing contentWhy
The optional opening tag allowed
.*?</think>to consume ordinary model output. A malformed provider response containing only</think>could therefore silently truncate everything before it.Fixes #3689.
Tests
python3focused assertions covering 6 think-block casespython3 -m py_compile backend/utils/str_utils.py test/backend/utils/test_str_utils.pygit diff --check