Repository navigation
Let the SQL surface tests report a MEOS error as JMEOS raises it - #68
Merged
estebanzimanyi merged 1 commit intoOct 5, 2026
Merged
Conversation
GeneratedSqlSurfaceTest and SqlSurfaceOverUdfSurfaceTest install no MEOS error handler and neither initialise nor finalise MEOS: every GeneratedFunctions wrapper runs GeneratedFunctions.ensureReady() first, which initialises MEOS once per process and installs MeosErrorHandler, and reads MeosErrorHandler.checkError() after the call, which rethrows the error MEOS reported as a typed MeosException. A handler installed over MeosErrorHandler records nothing, so a failed call answers false or NULL, and meos_initialize() puts back MEOS's default handler, which ends the process; a finalization frees the timezone and collation of the thread that ensureReady() does not set up again. Each test stops its Spark session after its tests. Measured against MobilityDB master c435dc7863, the catalog of MEOS-API 993b4dbacf and the jar of JMEOS main bc444c92: the 34 tests pass and the build prints no warning. Why: MEOS reports an error through the handler JMEOS installs, so a test leaves that handler in place and receives the error as the exception it raises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest and SqlSurfaceOverUdfSurfaceTest install no MEOS error handler and neither
initialise nor finalise MEOS: every GeneratedFunctions wrapper runs GeneratedFunctions.ensureReady()
first, which initialises MEOS once per process and installs MeosErrorHandler, and reads
MeosErrorHandler.checkError() after the call, which rethrows the error MEOS reported as a typed
MeosException. A handler installed over MeosErrorHandler records nothing, so a failed call answers
false or NULL, and meos_initialize() puts back MEOS's default handler, which ends the process; a
finalization frees the timezone and collation of the thread that ensureReady() does not set up
again. Each test stops its Spark session after its tests.
Measured against MobilityDB master c435dc7863, the catalog of MEOS-API 993b4dbacf and the jar of
JMEOS main bc444c92: the 34 tests pass and the build prints no warning.
Why: MEOS reports an error through the handler JMEOS installs, so a test leaves that handler in
place and receives the error as the exception it raises.