Repository navigation
Pass the upper border to the value split and tiles of the set-returning test - #62
Merged
estebanzimanyi merged 1 commit intoOct 1, 2026
Conversation
…ng test GeneratedSurfaceTest calls tint_value_split and tintbox_value_tiles with the border_inc argument the catalog states before their output parameters, as true, the SQL default of valueSplit and valueTiles. The tint's values 1 and 2 stay below the upper border 3 of a grid of size 1 from 0, so the test reads the same two bins and the same first tile index 1. Witness. Against MobilityDB 7b2a5c6e96, whose grids state their upper border with borderInc, set_returning_rows_as_arrays failed: "The `tint_value_split` requires 4 parameters but the actual number is 3", and then the same for tintbox_value_tiles. Measured. Against MobilityDB 7b2a5c6e96, the catalog of MEOS-API 0a54dfe443 and the generator of JMEOS main f90659aa, the build succeeds and the 22 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSurfaceTest calls tint_value_split and tintbox_value_tiles with the border_inc
argument the catalog states before their output parameters, as true, the SQL default of
valueSplit and valueTiles. The tint's values 1 and 2 stay below the upper border 3 of a grid of
size 1 from 0, so the test reads the same two bins and the same first tile index 1.
Witness. Against MobilityDB 7b2a5c6e96, whose grids state their upper border with borderInc,
set_returning_rows_as_arrays failed: "The
tint_value_splitrequires 4 parameters but theactual number is 3", and then the same for tintbox_value_tiles.
Measured. Against MobilityDB 7b2a5c6e96, the catalog of MEOS-API 0a54dfe443 and the generator of
JMEOS main f90659aa, the build succeeds and the 22 tests pass.