Repository navigation
Advance the MEOS commit and regenerate the UDF surface - #462
Merged
Merged
Conversation
The parity test of the window aggregates calls the window average wAvgAgg, the name the MEOS catalog states for Tnumber_wavg_transfn and the name the regenerated aggregates register, and doc/PARITY.md lists it among the aggregates MobilityDuck names with an Agg suffix. Why: DuckDB names its weighted average wavg, an alias of weighted_avg(x, weight), and compares function names without case, so a call to wAvg binds to DuckDB's weighted average and multiplies the temporal value by the interval: `No function matches the given name and argument types '*(tint, INTERVAL)'`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance the MEOS commit and regenerate the UDF surface
Call the window average wAvgAgg
The parity test of the window aggregates calls the window average wAvgAgg, the name the MEOS
catalog states for Tnumber_wavg_transfn and the name the regenerated aggregates register, and
doc/PARITY.md lists it among the aggregates MobilityDuck names with an Agg suffix.
Why: DuckDB names its weighted average wavg, an alias of weighted_avg(x, weight), and compares
function names without case, so a call to wAvg binds to DuckDB's weighted average and multiplies
the temporal value by the interval:
No function matches the given name and argument types '*(tint, INTERVAL)'.