fix(perps): handle liquidation price request failures - #6547
Merged
Conversation
Retry only 500 errors, stop polling on other failures, and skip liquidation price estimates below the minimum margin.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates liquidation-price estimation to avoid unnecessary retries and invalid requests.
Changes:
- Retry only error code 500; stop on other failures.
- Skip estimates below the market minimum.
- Share and unit-test retry/request policy.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
LiquidationPriceRequestTest.kt |
Tests retry and minimum-amount behavior. |
PerpsAddBottomSheetDialogFragment.kt |
Applies shared policy to add-position estimates. |
PerpetualViewModel.kt |
Returns structured estimation results. |
OpenPositionPage.kt |
Applies minimum validation and retry handling. |
LiquidationPriceRequest.kt |
Defines shared result and retry logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-on open/add position screensminAmountRoot cause
Both position screens treated every failed estimate as a temporary failure and retried indefinitely. The ViewModel returned only a nullable price, so callers could not distinguish server errors from non-retryable failures.
User impact
Open and add-position screens no longer repeatedly request liquidation prices for non-500 errors, and invalid below-minimum amounts do not trigger the estimate API.
Validation
./gradlew :app:testGooglePlayDebugUnitTest --tests one.mixin.android.ui.home.web3.trade.perps.LiquidationPriceRequestTest