Repository navigation
Fail Environments whose compute does not start - #940
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
codex/compute-start-deadline
branch
from
November 7, 2026 10:06
9a8095b to
8b57057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Provider can leave an allocation's compute pending or failed forever:
Createsettles but the sandbox never runs,GetInfokeeps failing, or a node never confirms. Core waited indefinitely, called noKill, and a standalone Environment stayedpendingbecause the pinned API has no Environment delete.Killand releases it onceCreateis settled. Eligibility is decided under the cleanup lock by the database clock; an allocation that ever ran is never affected.Killeven whenGetInfokeeps failing;Killverifies ownership itself, an ownership mismatch still refuses, and release still requires a settledCreate. This also unblocks Session deletion on an unreachable Provider.The Provider guide's timeouts table owns the value; the Environments lifecycle links to it (en/zh).
Tests:
TestComputeThatNeverStartsFailsStandaloneEnvironmentAtDeadline(fails without either change),TestRunningAllocationIsNeverFailedByStartDeadline, and the cleanup tests for an unavailable or unknown observation now expectKillwhile the allocation stays retained and its Create unsettled.Generated with Claude Code