Repository navigation
Run every official-client integration test in CI - #937
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The integration shards skip every official-client test because they set no
OAC_TEST_OFFICIAL_SDK_PYTHON. Theapijob ran only an explicit list of 11 of the 36 such tests, so 25 never ran in CI. Nine of those need a real model and native daemon and stay manual. Of the remaining 16, one had rotted:TestTemplateNullSelectionOfficialClientPostgresstill expected 400 for network restrictions that the network policy now accepts..github/actions/official-sdkinstalls the client pinned bycontracts/agents-api/upstream.json. Theapijob and the integration shards both use it.OAC_TEST_OFFICIAL_SDK_PYTHON, so every official-client test in the package runs there. The explicit list inapi-acceptance.ymlis deleted.ci_plan.pyroutes the new action tobackend,apiandlint.nullinherits the Template'sdisabled;enabledis still rejected as a widening.docs/maintainers.md(en/zh): the backend row says the shards run with the pinned client.Verification
make check-ciandcheck-translationspass.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.