Add codex-harness-patterns plugin (v1.0.4, 23 Skills) - #33
Open
antianqi wants to merge 1 commit into
Open
Conversation
… a fresh PR ## What This is a **replacement PR** for the abandoned PR MiniMax-AI#18 ("Add codex-harness-patterns plugin"). PR MiniMax-AI#18 was opened with `head = base = main` (head SHA `9600667e`, a merge commit on the `origin/main` branch that also accumulated 51 other commits spanning MiniMax-AI#5 tool-map, MiniMax-AI#17 mcode-island, and the proposal hooks). That state, plus a 51-commit / 168-file drift vs. `upstream/main`, made the PR effectively unreviewable: every reviewer comment touched a different change than the one the PR was nominally about, and `update-branch` returned `expected head sha didn't match current head ref` (HTTP 422). amszuidas' round-8 P2 (2026-09-07T03:17:13Z, head `9600667e`) captured this exactly: "Please rebase after those dependencies merge, or remove the unrelated changes so this PR can be reviewed and merged as the codex-harness-patterns contribution alone." This commit is the second half of that recommendation: it ships the codex-harness-patterns contribution as a single, self-contained commit on a fresh branch `add-codex-harness-patterns` based on `upstream/main`. The old PR MiniMax-AI#18 will be closed without merge; this PR is the one that should be reviewed. ## Why a single commit, not 30 The original 30-commit history (`fb0b87d` v0.3.0 origin through `c949789` v1.0.4 final, post-round-7) is available on the abandoned PR MiniMax-AI#18 branch. I attempted to cherry-pick those 30 commits onto a fresh `add-codex-harness-patterns` branch (preserving the review trail commit-by-commit), and got 30 modify/delete conflicts in a row: each commit is a "create + immediately modify" of the same files relative to the empty upstream, which git's 3-way merge does not handle in a non-interactive batch. Resolving 30 conflicts by hand does not preserve the review trail any better than a single squash, and is much noisier to audit. The end state of `c949789` (post-round-7) is what the reviewers ultimately agreed on; the 14 round-by-round commits are an artefact of the review process, not of the contribution itself. If a reviewer needs to see the round-by-round reasoning, the old PR MiniMax-AI#18's commit list, review comments, and round-by-round explanations remain at `https://github.com/MiniMax-AI/MiniMax-Code-Plugins/pull/18` after this PR replaces it. The abandoned PR is referenced explicitly in the new PR's body (see "Replacement of" below). ## What this PR contains Exactly two paths: - `plugins/antianqi/codex-harness-patterns/` — the plugin itself: `plugin.json` + `LICENSE` + `README.md` (4-section disclosure: no credentials / no network / no telemetry / no third-party services) + `OVERVIEW.md` + `PR-STATUS.md` + 23 Skills. - `test/codex-harness-patterns.test.mjs` — the static-check companion to the plugin (closes round-4 false-green holes, pins mcode 0.2.4 task contract, asserts minMcodeVersion). No other files change. The 30-commit PR MiniMax-AI#18 also touched `.github/workflows/`, `test-fixtures/`, `plugins/antianqi/tool-map/`, `plugins/antianqi/mcode-island/`, etc. — none of that is in this PR. ## Skill list (v1.0.4) background-task, completion-audit, context-pressure-compact, delegate-with-context, error-recovery-strategy, fork-context-decision, goal-persistence, goal-token-budgeting, long-term-memory, model-router, parallel-fanout, plan-stream-emit, plugin-author-helper, retry-with-backoff, review-mode, session-branch-fork, session-handoff, skill-auto-select, streaming-output-reader, subagent-family-tracking, tool-discovery-pattern, tool-output-budget, world-state-tracking. ## Test evidence ``` $ git checkout c949789 -- plugins/antianqi/codex-harness-patterns test/codex-harness-patterns.test.mjs $ git diff --cached --name-only | wc -l 29 $ ls plugins/antianqi/codex-harness-patterns/skills | wc -l 23 ``` `plugins/antianqi/codex-harness-patterns/scripts/smoke.mjs` (static-check that runs as part of `npm run check` on this plugin) will run under the `validate (windows-latest)` / `validate (ubuntu-latest)` jobs in this PR's CI matrix. ## Design compliance - **One Plugin, one commit, one branch, one PR.** The entire contribution is `plugins/antianqi/codex-harness-patterns/` (the plugin) plus `test/codex-harness-patterns.test.mjs` (its static-check companion). 29 files total. No workflow changes, no shared-test changes, no scope creep into other plugins. (The old PR MiniMax-AI#18 also touched `.github/workflows/`, `test-fixtures/`, and other plugins; those are explicitly NOT in this PR.) - **No credentials, no network, no telemetry, no third-party services.** All 23 Skills are local prompts and references; no HTTP, no token, no telemetry endpoint. - **README 4-section disclosure (v1.0.2, round-3):** `plugins/antianqi/codex-harness-patterns/README.md` contains a "What this Plugin does NOT do" section explicitly listing the four absences above, following the mcode plugin convention introduced by the round-2 / round-3 disclosure review. - **Replacement of** PR MiniMax-AI#18 (the 51-commit / 168-file / `head=base=main` / "rebase or remove the unrelated changes" one). The old PR's commit list and review history are preserved on the closed PR for audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement of PR #18
This is a fresh, self-contained PR for the
codex-harness-patternscontribution. It replaces the abandoned PR #18, which had become unreviewable (51 commits / 168 files / head=base=main, with codex-harness-patterns mixed into the same change as #5 tool-map, #17 mcode-island, and the proposal hooks - exactly the "remove the unrelated changes" shape that amszuidas' round-8 P2 (2026-09-07T03:17:13Z) asked to be cleaned up).What this PR contains
Two paths, 29 files, 6112 insertions:
plugins/antianqi/codex-harness-patterns/- the plugin itself:plugin.json+LICENSE+README.md(4-section disclosure: no credentials / no network / no telemetry / no third-party services) +OVERVIEW.md+PR-STATUS.md+ 23 Skills.test/codex-harness-patterns.test.mjs- the static-check companion (closes round-4 false-green holes, pins mcode 0.2.4 task contract, assertsminMcodeVersion).No other files change. The 30-commit history of the old PR #18 (
fb0b87dv0.3.0 origin throughc949789v1.0.4 final) is collapsed into one commit here; the round-by-round reasoning remains at #18 (closed, but readable).Skill list (v1.0.4)
background-task, completion-audit, context-pressure-compact, delegate-with-context, error-recovery-strategy, fork-context-decision, goal-persistence, goal-token-budgeting, long-term-memory, model-router, parallel-fanout, plan-stream-emit, plugin-author-helper, retry-with-backoff, review-mode, session-branch-fork, session-handoff, skill-auto-select, streaming-output-reader, subagent-family-tracking, tool-discovery-pattern, tool-output-budget, world-state-tracking.
What this PR does NOT contain (by design)
.github/workflows/changes. The old PR Add codex-harness-patterns plugin (v1.0.3 - 23 Skills covering complete agent lifecycle: planning, decomposition, sub-agent parallelism, execution, state tracking, tool discovery, skill/plugin authoring, memory persistence, session branching) #18 copiedtool-map-windows.ymlandmcode-island-windows.ymlto the main branch so the windows-latest CI could find them; those workflows belong to the windows-latest job of the tool-map / mcode-island PRs, not to this one.plugins/antianqi/tool-map/changes. Those are PR Add antianqi/tool-map v0.2.0: persistent cross-platform tool inventory #5.plugins/antianqi/mcode-island/changes. Those are PR mcode-island v0.3.0: add io.minimax.mcode Hooks extension (forward-compat with PR #20) #21.test-fixtures/changes. The twodrive-bundle-failure*.mjsfixtures in the old PR Add codex-harness-patterns plugin (v1.0.3 - 23 Skills covering complete agent lifecycle: planning, decomposition, sub-agent parallelism, execution, state tracking, tool discovery, skill/plugin authoring, memory persistence, session branching) #18 were part of PR Add antianqi/tool-map v0.2.0: persistent cross-platform tool inventory #5 tool-map test suite; not relevant here.validate / analyze / CodeQLmatrix without dispatch.Test evidence
The Plugin own
scripts/smoke.mjsstatic-check (no hardcoded host paths; no third-party services; frontmatter contract) will run as part ofnpm run checkon this PR CI matrix.Design compliance
Note on review history
This contribution went through 14 rounds of review on the abandoned PR #18 (
fb0b87dv0.3.0 toc949789v1.0.4). The reviewer feedback (round-3 README 4-section disclosure, round-4 false-green holes, round-5 self-contradictions + plugin.json minMcodeVersion + SKILL.md path claim, round-7 mcode 0.2.4 pin) is all incorporated into the single commit here. If a reviewer wants to see the round-by-round reasoning or the exact wording of any specific reviewer comment, those are on the closed PR #18 linked above.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.