Select multiple words/lines when double/triple clicking.

[RobertP-McDowell]

Proposed changes

Quality of life feature for mouse users. Many text editors have the ability to drag select words and lines, and mcedit already allows you to select one word at a time, this is just an improvement of what's already there!

Also updated how the delay between clicks works to start the timer on mouse down instead of up, this is a lot more common in text editors (your very browser probably behaves this way); this change affects all other widgets that use double-click functionality.

• Resolves: #... (No prior issue I could find)

Checklist

• I have referenced the issue(s) resolved by this PR (if any)
• I have signed-off my contribution with git commit --amend -s
• Lint and unit tests pass locally with my changes (make indent && make check)
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)

Tested with both gpm and xterm-only mouse support, ncurses, and slang.

[ossilator]

the commit messages lack explanations/justifications of the changes.

also, judging by the commit message, the 2nd commit mixes two unrelated changes.

[RobertP-McDowell]

I made each commit message clearer, and I thought changing the click time delay was an important enough change to warrant a third commit after all, so I split up the 2nd commit into two.

[RobertP-McDowell]

I changed the functionality a bit so double clicking will always select at least one character in my last force-push, and resolved the reviewed changes. Thanks.

[mc-worker]

Thanks! Double click to select a word and a triple click to select a line work fine. But the descriptions of the 2nd commit is unclear for me.

Highlight multiple lines when triple clicking in mcedit.

Like the last commit, improves triple clicking to allow the user to drag select multiple lines on double clicking in the editor.

Could you please describe how it should work?

[RobertP-McDowell]

So what's the next step to get this feature merged? Is it a matter of whether or not it is wanted at this point? I've been using it since, and it works as expected. Also If/When I need to update my branch, should I avoid a merge commit?

[mc-worker]

/rebase

[mc-worker]

@RobertP-McDowell I rebased your branch but cannot merge it because some checks failed:

Indentation:

diff --git a/src/editor/edit.c b/src/editor/edit.c
index 87583d6..e423747 100644
--- a/src/editor/edit.c
+++ b/src/editor/edit.c
@@ -946,10 +946,10 @@ edit_get_current_word_extents (WEdit *edit, off_t *start, off_t *end)
 
         if (is_break_char (check_char))
         {
-            if (pos == edit->buffer.curs1) // always select at least one character.
+            if (pos == edit->buffer.curs1)  // always select at least one character.
             {
                 *start = pos;
-                *end = pos+1;
+                *end = pos + 1;
                 return;
             }
             break;

DCO:

Commit sha: a4416e6, Author: robert, Committer: Andrew Borodin; Expected "robert teatimewithrobert@gmail.com", but got "Robert P. McDowell teatimewithrobert@gmail.com".
Commit sha: fec3f74, Author: robert, Committer: Andrew Borodin; Expected "robert teatimewithrobert@gmail.com", but got "Robert P. McDowell teatimewithrobert@gmail.com".

[RobertP-McDowell]

Thanks! I had to push --force-with-lease to fix the DCO, you may have to do the same on the rebase branch, I'm not sure.

[mc-worker]

Thanks!