user story #3060002: Security: enforce use of pinned versions in bdd2… - #60
Merged
Merged
Conversation
nissimshitrit
previously requested changes
Aug 18, 2026
swar30
reviewed
Aug 19, 2026
swar30
approved these changes
Aug 19, 2026
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-enforcer-plugin</artifactId> | ||
| <version>3.5.0</version> |
There was a problem hiding this comment.
swar30
dismissed
nissimshitrit’s stale review
August 19, 2026 08:41
relevant changes removed from pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security: enforce pinned dependency versions + fix cross-platform feature
pathStory: #3060002
What changed
pom.xml— Addedmaven-enforcer-plugin(3.5.0), bound to thevalidatephase, with two rules:banDynamicVersions(allowSnapshots=false) — bans version ranges,LATEST,RELEASE,+,*, and SNAPSHOTs.requireReleaseDeps— fails the build if any dependency resolves to a SNAPSHOT.OctaneFeature.java— Normalized thepathattribute written to the Octane result XML to forward slashes:Why
Bdd2OctaneHandlerITCase(test36 - CUCUMBER_JVM) failed on Windows because the emittedpathused the OS-native separator (\on Windows vs/on Linux), causing aCompareXmlmismatch against the fixtures and producing platform-dependent Octane output.How it was implemented
validate), so a dynamic/SNAPSHOT dependency stops the build before compilation. The two rules map directly to the policy's required actions./at the single point where it is written to XML. On Linux paths are already/-based (no-op); on Windows\is converted to/, yielding consistent, platform-independent output.How it was tested
mvn validate→ both enforcer rules pass with current pinned dependencies.[0.9,)) → build failed with a clear enforcer error, then reverted.mvn clean verifyon Windows → BUILD SUCCESS, all 38 tests pass (0 failures, 0 errors). This same run previously failed ontest36 - CUCUMBER_JVM.