fix: avoid type-mutation bug in display_tp_fp_fn and normalize image_ids - #82
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
Collaborator
|
@botbikamordehai2-sketch I am very sure it does not close the mentioned #80 by far |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens PreviewResults.display_tp_fp_fn against mixed-type image_ids inputs by normalizing IDs and using an explicit existence check so valid images aren’t skipped due to key-type mismatches.
Changes:
- Normalize non-
["all"]image_idsvalues tointbefore iterating. - Replace
dict.get(...) is Nonewithimage_id not in self.cocoGt.imgsfor existence checking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+91
to
+93
| else: | ||
| # Normalize image_ids to int to avoid KeyError from type mismatch | ||
| image_ids = [int(i) for i in image_ids] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
display_tp_fp_fnmethod allowedimage_idsto be a mixed list of ints and strings (e.g., from user input). The.get()call with a string key on an int-keyed dict silently fails (returns None) and causes some images to be skipped with a warning. Moreover, the method mutates theimage_idslist when== ["all"]but does not protect against subsequent mutation ofself.cocoGt.imgsduring iteration.Fix
[int(i) for i in image_ids]to ensure type consistency with the keys ofself.cocoGt.imgs.image_id not in self.cocoGt.imgsfor existence check instead of.get()to avoid silent miss.Closes #80