Rename project date fields: close_date → winners_announced_date, forecasting_end_date → close_date

[SylvainChevalier]

Closes #4394.

Summary

Align backend naming with user-facing labels:

• close_date (deadline / prizes paid) → winners_announced_date
• forecasting_end_date (last scored question close) → close_date
• Improved help_text on both fields per @skmmcj's wording
• Renamed move_project_forecasting_end_date → move_project_close_date
• Frontend types, components, mock data, sort enum, and i18n placeholders updated
• Migration 0024 swaps the two columns via a temporary name

Test plan

• manage.py migrate applies cleanly on a fresh DB and on a DB migrated up to 0023
• Tournament list page renders with the “Ending soon” sort (now winners_announced_date)
• Tournament detail “Winners announced” row still appears in the stats dropdown
• Approving a question past the tournament close date still triggers the “move date” modal
• Frontend typecheck passes
• Backend tests pass

Generated with Claude Code

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 028bb6e8-06b6-4fb5-ad22-3b0e667e0582

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/issue-4394-rename-project-fields-date-fields

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Preview Environment

Your preview environment is ready!

Resource	Details
🌐 Preview URL	https://metaculus-pr-4741-claude-issue-4394-rename-proje-preview.mtcl.cc
📦 Docker Image	ghcr.io/metaculus/metaculus:claude-issue-4394-rename-project-fields-date-fields-1626101
🗄️ PostgreSQL	NeonDB branch preview/pr-4741-claude-issue-4394-rename-proje
⚡ Redis	Fly Redis mtc-redis-pr-4741-claude-issue-4394-rename-proje

Details

• Commit: f90a69b8d4603f1f7ea3505cedb057729e6b7e02
• Branch: claude/issue-4394-rename-project-fields-date-fields
• Fly App: metaculus-pr-4741-claude-issue-4394-rename-proje

---

ℹ️ Preview Environment Info

Isolation:

• PostgreSQL and Redis are fully isolated from production
• Each PR gets its own database branch and Redis instance
• Changes pushed to this PR will trigger a new deployment

Limitations:

• Background workers and cron jobs are not deployed in preview environments
• If you need to test background jobs, use Heroku staging environments

Cleanup:

• This preview will be automatically destroyed when the PR is closed

[hlbmtc]

This needs to be carefully reviewed & tested. Also, we should keep old field ref in serializers for backward compatibility in case someone is using our projects API

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will not be closed automatically, but please consider updating it or closing it if it is no longer relevant.