Skip to content

chore: bump accounts deps - #9754

Merged
ccharly merged 14 commits into
mainfrom
cc/chore/bump-accounts-deps
Aug 4, 2026
Merged

chore: bump accounts deps#9754
ccharly merged 14 commits into
mainfrom
cc/chore/bump-accounts-deps

Conversation

@ccharly

@ccharly ccharly commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Explanation

Aligning accounts deps.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Touches many packages that depend on the keyring and account APIs with several major semver upgrades, but the PR does not change controller logic—risk is mainly version skew and downstream breaking API behavior from the bumped packages.

Overview
This PR aligns MetaMask accounts/keyring dependency versions across many packages/* workspaces so core stays in sync with extension and mobile consumers (#9754).

Keyring stack (major bumps): @metamask/keyring-api ^24.0.0, @metamask/keyring-internal-api ^12.0.0, @metamask/keyring-utils ^5.0.0, @metamask/keyring-sdk ^3.1.0, @metamask/account-api ^2.0.0, @metamask/eth-snap-keyring ^24.0.0, @metamask/keyring-snap-client ^10.0.0, and related bumps on HD/simple/money keyrings and snap clients. Controllers such as keyring-controller, accounts-controller, multichain-account-service, and snap-account-service pick these up via package.json only.

Validation library: @metamask/superstruct is raised from ^3.1.0 to ^3.4.1 broadly (RPC middleware, wallet-cli, data services, etc.).

Changes are lockfile + changelog entries; there are no application source edits in this diff.

Reviewed by Cursor Bugbot for commit 81a0d30. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread yarn.lock Outdated
languageName: unknown
linkType: soft

"@metamask/eth-money-keyring@npm:^2.0.4":

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going from 2 to 4 here, but the client (feature available on mobile only for now) was already using previous major 3. The new major 4 is mostly because we removed some EOL node.js support, so no real bad surprises to be expected here.

@ccharly
ccharly marked this pull request as ready for review August 3, 2026 09:11
@ccharly
ccharly requested review from a team as code owners August 3, 2026 09:11
@ccharly
ccharly temporarily deployed to default-branch August 3, 2026 09:11 — with GitHub Actions Inactive

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cf0e708. Configure here.

Comment thread packages/money-account-controller/package.json
@ccharly
ccharly enabled auto-merge August 3, 2026 09:16
exportable: false,
},
methods: [
EthMethod.SignTransaction,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this now. Since @metamask/eth-money-keyring@3.0.0 the handler for this method got removed. Those accounts are not supposed to sign transactions.

The mobile client (only client that uses money accounts for now), is already using this version too: https://github.com/MetaMask/metamask-mobile/blob/920629a885551f8dbf4ab523b1a4b352d9a84cd2/package.json#L288

I'll make a migration to clear up this method from the existing money accounts once aligning our deps there!

Comment thread packages/money-account-controller/src/MoneyAccountController.ts
@ccharly
ccharly requested review from a team as code owners August 4, 2026 16:34
@ccharly
ccharly requested review from a team as code owners August 4, 2026 16:34
### Changed

- Bump `@metamask/keyring-api` from `^23.7.0` to `^24.0.0` ([#9754](https://github.com/MetaMask/core/pull/9754))
- Bump `@metamask/superstruct` from `^3.1.0` to `^3.4.1` ([#9754](https://github.com/MetaMask/core/pull/9754))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bumping @metamask/superstruct since I'll soon use the new sensitive struct from this version!

@mcmire mcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ccharly
ccharly added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit 66c3cff Aug 4, 2026
432 checks passed
@ccharly
ccharly deleted the cc/chore/bump-accounts-deps branch August 4, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants