[cryptotavares]

Description

MobilePlatformDriver.click returns {clicked: true} once the backend call resolves, so B2 (click --testid log-in-button under the iOS keyboard) was a false success. An agent cannot tell a covered target from a missed one.

This PR (with MetaMask/device-mcp#51, which refuses such taps):

• New MM_TARGET_OBSCURED for device-mcp TARGET_OBSCURED. device-mcp ELEMENT_NOT_IN_VIEWPORT (tap on an off-screen element) → MM_TARGET_NOT_VISIBLE. classifyInteractionError checks these typed codes before the text patterns (a message with "not found" in it is still MM_TARGET_OBSCURED).
• click --dismiss-keyboard (dismissKeyboard: true): when the keyboard is the cover (keyboard: true), dismiss it, look up the element again (the layout can move), and tap once more. The result has keyboardDismissed: true. An overlay that is not the keyboard is never dismissed.
• Mobile click result gains screenChanged when an observation is collected: whether the observed screen differs (refs ignored) from the last screen the agent received before the click. false is a hint, not an error. It is omitted with --observe none.
• Browser click unchanged.
• SKILL.md / README: the new codes, --dismiss-keyboard, screenChanged.

Part of the mm CLI v2 effort: ticket P1-42 (Phase 1). Stacked on #76 (review that first; GitHub stack #75).
Depends on MetaMask/device-mcp#51 (needs a device-mcp release before merge). With device-mcp 0.7.0, nothing changes for taps (no TARGET_OBSCURED is thrown).

Breaking changes

None. A mobile click that silently tapped something else now fails with MM_TARGET_OBSCURED / MM_TARGET_NOT_VISIBLE.

Consumer impact

Consumer	Change needed	Done on branch
Mobile tests/llm-workflow/	None. Workspace scripts that unlock now pass --dismiss-keyboard	n/a
Skills	Documented in SKILL.md	this PR

Proof

Same runs as MetaMask/device-mcp#51. Error codes are read from the daemon response (the CLI prints only the message until P1-16).

Check	Before (#76 + device-mcp #50)	After
iOS B2 click --testid log-in-button, keyboard up	{"clicked": true}, still on login	MM_TARGET_OBSCURED naming the keyboard; nothing tapped
iOS B2 --dismiss-keyboard	n/a	{"clicked": true, "keyboardDismissed": true} → unlocked
iOS click p50 (15 runs)	1245 ms	1420 ms (+175 ms; AC ≤ +0.4 s)
Android tap below the fold	{"clicked": true}	MM_TARGET_NOT_VISIBLE
screenChanged: Home tab (already open) / profile button	n/a	false / true
Extension smoke (launch, unlock click, describe, state, cdp, screenshot)	n/a	all exit 0; browser click result unchanged (no screenChanged)

Unit tests

• Driver: keyboard-obscured + dismissKeyboard → dismiss, re-wait, tap the new element, keyboardDismissed: true; no option → error unchanged; overlay (keyboard: false) → no dismiss; still covered → error after one retry; abort during dismiss → no second tap.
• classifyInteractionError: typed TARGET_OBSCURED / ELEMENT_NOT_IN_VIEWPORT before text patterns.
• withScreenChanged: changed / unchanged (refs ignored) / every skip case (other tool, failed click, no observation, no earlier screen, browser, no driver).
• CLI: --dismiss-keyboard sends dismissKeyboard: true and is never read as the target. Schema: boolean only.

 Test Files  54 passed (54)
      Tests  1876 passed (1876)
Coverage (CI=1): Statements 97.57% | Branches 95.03% | Functions 96.78% | Lines 97.72%
yarn lint: clean