fix(keyring-eth-ledger-bridge): stop using pinned version - #616
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ccharly
marked this pull request as ready for review
August 5, 2026 10:52
ccharly
enabled auto-merge
August 5, 2026 11:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why, but this version got pinned, which makes it much hard to dedupe valid version ranges.
Also updated our
yarn.config.cjsto prevent this from happening again.Note
Low Risk
Dependency and tooling-only changes with no application logic edits; the main effect is resolving a newer compatible
@ledgerhq/context-modulevia the lockfile.Overview
Replaces the accidentally pinned
@ledgerhq/context-moduledependency (2.1.0) in@metamask/eth-ledger-bridge-keyringwith^2.1.0, so Yarn can align it with other compatible ranges in the monorepo. The lockfile refresh pulls@ledgerhq/context-module@2.3.1(still satisfying^2.1.0).Adds a Yarn constraints check (
expectNoPinnedExternalDependencies) that fails on exact external versions independencies/devDependencies, with an emptyPINNED_VERSION_EXCEPTIONSlist for intentional pins. The unreleased changelog notes the dependency change.Reviewed by Cursor Bugbot for commit 5801acd. Bugbot is set up for automated code reviews on this repo. Configure here.