feat: add originMetadata to submitRequest - #615
Open
FrederikBolding wants to merge 11 commits into
Open
Conversation
originMetadata to submitRequestoriginMetadata to submitRequest
FrederikBolding
marked this pull request as ready for review
August 6, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
originMetadatafield tosubmitRequest, which will only be passed down in v2 keyrings or in v1 keyrings that are using at least platform version12. This field can be used when using transports where theoriginitself isn't verifiable.Note
Medium Risk
Touches signing request routing and platform-gated payload shaping; backward compatibility is explicit but wrong version checks could break older Snaps or omit metadata for new ones.
Overview
Adds optional
originMetadata(transport,selfReportedOrigin) onKeyringRequestand threads it throughsubmitRequestso Snaps can reason about callers when the origin string alone is not trustworthy (e.g. WalletConnect).SnapKeyring/SnapKeyringV1choose the RPC shape from Snap platform version: ≥12.0.0 sends full requests (including metadata when provided); 7.0.0–11.x uses newtoKeyringRequestWithoutOriginMetadata/submitRequestWithoutOriginMetadata; older platforms still striporigin.toKeyringRequestWithoutOriginnow also dropsoriginMetadata.EthKeyringV1Adapteralways passesoriginMetadata: nullon internal submits.Reviewed by Cursor Bugbot for commit 45a2677. Bugbot is set up for automated code reviews on this repo. Configure here.