feat(keyring-sdk): add decodeMnemonic{,Words} - #612
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
ccharly
marked this pull request as ready for review
August 3, 2026 09:41
ccharly
enabled auto-merge
August 3, 2026 11:04
mathieuartu
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding helpers for mnemonics.
Note
Low Risk
Additive SDK API with tests and no changes to existing encode behavior; mnemonic handling is sensitive in principle but this only adds parsing helpers consistent with existing encoders.
Overview
Adds decode helpers in
keyring-sdkthat mirror the existingencodeMnemonic/encodeMnemonicWordsAPIs, turning BIP-39 English mnemonics back into 16-bit word-index byte buffers.decodeMnemonicWordssplits a space-separated phrase and maps each word through the English wordlist;decodeMnemonicUTF-8-decodes bytes first, then delegates todecodeMnemonicWords. Both reject unknown words withInvalid mnemonic word: "…". Tests cover empty input, round-trip withencodeMnemonic, and invalid-word errors. The unreleased changelog entry documents the new exports.Reviewed by Cursor Bugbot for commit 914f87e. Bugbot is set up for automated code reviews on this repo. Configure here.