chore(renovate): hold typescript below v7 until astro check supports it - #12778
Closed
jd wants to merge 1 commit into
Closed
chore(renovate): hold typescript below v7 until astro check supports it#12778jd wants to merge 1 commit into
jd wants to merge 1 commit into
Conversation
TypeScript 7 (the native/Corsa compiler) does not ship the programmatic API astro check relies on. astro check fails outright once typescript resolves to 7.x: The TypeScript module loaded (found 7.0.2) does not expose the programmatic API that `astro check` relies on. TypeScript's native compiler (7.0 and later) does not ship this API yet. @astrojs/language-server is already at its latest published release (2.16.16) with no newer version to pick up, so there is no fix to upgrade into yet. astro check is the only thing type-checking .astro files in this repo, so it stays in the lint script rather than being dropped to make a version number fit. Add a packageRule constraining typescript to `<7.0.0` so renovate stops proposing v7 bumps, with a description pointing at the missing API and the upstream tracking issue so the hold reads as a decision rather than an unexplained pin. 6.x patch releases still flow normally. Supersedes #12585, which stays open for renovate to retire once this lands (closing it directly would only suppress 7.0.2 specifically — 7.0.3 would come back next week, red again, with no record of why). Upstream tracking: withastro/roadmap#1321 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Change-Id: Ibeb3452b2cb5e6258624031fb5e8e06022779a23
Contributor
Merge Protections🔴 2 of 6 protections blocking · waiting on 👀 reviews
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
Show 4 satisfied protections🟢 🤖 Continuous Integration
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
1 task
There was a problem hiding this comment.
🟢 Approval recommended
The scoped configuration change has no unresolved blocking issues.
Pull request overview
This PR updates Renovate configuration to hold TypeScript below 7.0.0 until Astro supports its compiler API.
Changes:
- Restricts TypeScript to versions below 7.0.0.
- Documents the compatibility rationale and upstream tracking issue.
File summaries
| File | Summary |
|---|---|
renovate.json |
Adds the TypeScript version constraint and rationale. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
ok not needed i guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 7 (the native/Corsa compiler) does not ship the programmatic
API astro check relies on. astro check fails outright once typescript
resolves to 7.x:
The TypeScript module loaded (found 7.0.2) does not expose the
programmatic API that
astro checkrelies on. TypeScript's nativecompiler (7.0 and later) does not ship this API yet.
@astrojs/language-server is already at its latest published release
(2.16.16) with no newer version to pick up, so there is no fix to
upgrade into yet. astro check is the only thing type-checking .astro
files in this repo, so it stays in the lint script rather than being
dropped to make a version number fit.
Add a packageRule constraining typescript to
<7.0.0so renovate stopsproposing v7 bumps, with a description pointing at the missing API and
the upstream tracking issue so the hold reads as a decision rather than
an unexplained pin. 6.x patch releases still flow normally.
Supersedes #12585, which stays open for renovate to retire once this
lands (closing it directly would only suppress 7.0.2 specifically —
7.0.3 would come back next week, red again, with no record of why).
Upstream tracking: withastro/roadmap#1321
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com