Skip to content

fix(test-insights): link the four framework pages that only mentioned the dashboard - #12758

Open
flagendijk89 wants to merge 1 commit into
mainfrom
devs/frank/fix-test-framework-review-cta/I7df67cc209a1cded4473b4667caf1653c7a8f73e
Open

fix(test-insights): link the four framework pages that only mentioned the dashboard#12758
flagendijk89 wants to merge 1 commit into
mainfrom
devs/frank/fix-test-framework-review-cta/I7df67cc209a1cded4473b4667caf1653c7a8f73e

Conversation

@flagendijk89

@flagendijk89 flagendijk89 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Part of MRGFY-8998 — design polish review, August 2026.

pytest, playwright, rspec and vitest each ended a reader's setup with an
unlinked sentence — "Check the Test Insights dashboard afterward to view
execution metrics, detect flaky tests, and review test trends" — buried
in the middle of the CI workflow section. The other eleven framework
pages close with a "Verify and Review in Test Insights" section carrying
the actual dashboard link.

These four are the section's second page shape: they use a reporter,
plugin or gem that uploads directly with MERGIFY_TOKEN rather than
generating a JUnit report for the Mergify CI action to upload. That is
why the shared partial never reached them, and it is the same four pages
missing a Troubleshooting section.

Each now closes with the shared _review-in-test-insights.mdx partial
under the same heading the other eleven use, preceded by a line naming
what just happened so the partial's "You can then review..." has an
antecedent.

The shared troubleshooting partial is deliberately not added here. It is
written for the JUnit path — it talks about report_path, the CLI upload
step and workflow if conditions — and none of these four pages
reference any of that. Closing that gap needs framework-specific content
rather than a shared block.

Also normalises :::tip bodies in pytest and rspec to the 2-space indent
the rest of the docs use, and rewraps them to the surrounding column.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com


🤖 Generated with Claude Code

… the dashboard

pytest, playwright, rspec and vitest each ended a reader's setup with an
unlinked sentence — "Check the Test Insights dashboard afterward to view
execution metrics, detect flaky tests, and review test trends" — buried
in the middle of the CI workflow section. The other eleven framework
pages close with a "Verify and Review in Test Insights" section carrying
the actual dashboard link.

These four are the section's second page shape: they use a reporter,
plugin or gem that uploads directly with MERGIFY_TOKEN rather than
generating a JUnit report for the Mergify CI action to upload. That is
why the shared partial never reached them, and it is the same four pages
missing a Troubleshooting section.

Each now closes with the shared `_review-in-test-insights.mdx` partial
under the same heading the other eleven use, preceded by a line naming
what just happened so the partial's "You can then review..." has an
antecedent.

The shared troubleshooting partial is deliberately not added here. It is
written for the JUnit path — it talks about `report_path`, the CLI upload
step and workflow `if` conditions — and none of these four pages
reference any of that. Closing that gap needs framework-specific content
rather than a shared block.

Also normalises `:::tip` bodies in pytest and rspec to the 2-space indent
the rest of the docs use, and rewraps them to the surrounding column.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Change-Id: I7df67cc209a1cded4473b4667caf1653c7a8f73e
Claude-Session-Id: 18413631-aa75-4182-9e79-4c1ce31bb683
@mergify
mergify Bot deployed to Mergify Merge Protections September 9, 2026 13:45 Active
@mergify
mergify Bot requested a review from a team September 9, 2026 13:51
@mergify

mergify Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = diagram-tokens
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = renovate[bot]
    • all of:
      • author = mergify-ci-bot
      • -head ~= ^docs-agent/

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify
mergify Bot requested a review from a team September 9, 2026 13:53
@mergify

mergify Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants