Skip to content

feat(dsh): validate MemOS local adapter on DSH 0.2.2-rc.1 - #2614

Open
jwc19890114 wants to merge 1 commit into
MemTensor:mainfrom
jwc19890114:feat/dsh-0.2.2-rc1-compat
Open

jwc19890114 wants to merge 1 commit into
MemTensor:mainfrom
jwc19890114:feat/dsh-0.2.2-rc1-compat

Conversation

@jwc19890114

Copy link
Copy Markdown

Summary

Extend the MemOS local plugin's DeepSeek Harness compatibility to the published 0.2.2-rc.1 release. The previous integration supports hosts through 0.2.1; this adds an explicitly tested prerelease without admitting unvalidated future versions.

  • Allow 0.2.2-rc.1 for the six optional DSH service peers and update the lockfile.
  • Include 0.2.2-rc.1 in the isolated compatibility matrix, using its Cordis 4.1 peer and matching V3-to-V4 session codec.
  • Update the package test, adapter documentation, and changelog.

Verification

  • Isolated DSH 0.2.2-rc.1 fixture: TypeScript typecheck and build passed; 71 adapter tests passed.
  • Plugin package: 12 package tests passed; TypeScript typecheck and build passed.
  • Earlier isolated checks for DSH 0.2.1-rc.3 and 0.2.1 also passed with 71 adapter tests each.
  • On Windows, an isolated DSH Web profile completed a conversation and memos_search call; memory capture completed without warnings. A clone of the existing memory database migrated from schema 18 to 19, preserving baseline IDs and passing integrity and foreign-key checks. The production profile was not changed.

Refs #2520. Builds on the DSH integration from #2549.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T04:43:45.323341Z b71d9b4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Memtensor-AI Memtensor-AI added area:plugin OpenClaw & Hermes status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Nov 11, 2026
@Memtensor-AI

Copy link
Copy Markdown
Collaborator

🤖 Open Code Review

Target: PR #2614
Task: 56c8ed87c6d3d96f
Base: main
Head: feat/dsh-0.2.2-rc1-compat
Head SHA: b71d9b45128fec2ca50ef66ba9c33368f497cb42

🔍 OpenCodeReview found 4 issue(s) in this PR.


1. apps/memos-local-plugin/scripts/check-dsh-compatibility.mjs (L53-L55)

pkg.peerDependencies is dereferenced without a guard. Published metadata for a package without peer deps (or a version that drops the cordis peer) gives undefined here, which either throws a TypeError mid-matrix or assigns undefined to devDependencies["@deepseek-ai/cordis"] — JSON.stringify then silently drops the key, so the intended Cordis pin is lost and the fixture compiles against whatever Cordis npm resolves transitively. Guard the access and only override when the range exists.

💡 Suggested Change

Before:

      if (pkg.name === "@deepseek-ai/dsh-agent" && version === "0.2.2-rc.1") {
        devDependencies["@deepseek-ai/cordis"] = pkg.peerDependencies["@deepseek-ai/cordis"];
      }

After:

      const cordisPeer = pkg.peerDependencies?.["@deepseek-ai/cordis"];
      if (pkg.name === "@deepseek-ai/dsh-agent" && version === "0.2.2-rc.1" && cordisPeer) {
        devDependencies["@deepseek-ai/cordis"] = cordisPeer;
      }

2. apps/memos-local-plugin/scripts/check-dsh-compatibility.mjs (L36)

The special case for 0.2.2-rc.1 is hardcoded here and again in the Cordis override below, while 0.2.2-rc.1 is also listed in the default version matrix. That means every future host bump must be edited in three unrelated places: a newly added version (or an explicitly passed one, e.g. 0.2.2-rc.2) silently skips both special cases, leaving the helper codec pinned at 0.2.1-rc.3 and Cordis at ~4.0.5 while the rest of the graph moves to the new version. Consider a single per-version overrides map ({ "0.2.2-rc.1": { alignSessionFormat: true, cordisFromAgentPeer: true } }) so the exceptions are declared once and are discoverable when adding a version.


3. apps/memos-local-plugin/package.json (L111)

All other rc support is expressed as a train range (>=0.2.1-rc.2 <0.2.2), but the new line admits only the exact 0.2.2-rc.1. As soon as 0.2.2-rc.2/-rc.3 ships, installs against hosts that are functionally identical will emit peer-dependency warnings and this file needs another edit. Recommend using a range for consistency, e.g. >=0.2.2-rc.1 <0.2.3.

💡 Suggested Change

Before:

    "@deepseek-ai/dsh-agent": ">=0.1.0-rc.6 <0.2.0 || >=0.1.7-rc.2 <0.1.8 || >=0.2.0-rc.2 <0.2.1 || >=0.2.1-rc.2 <0.2.2 || 0.2.2-rc.1",

After:

    "@deepseek-ai/dsh-agent": ">=0.1.0-rc.6 <0.2.0 || >=0.1.7-rc.2 <0.1.8 || >=0.2.0-rc.2 <0.2.1 || >=0.2.1-rc.2 <0.2.2 || >=0.2.2-rc.1 <0.2.3",

4. apps/memos-local-plugin/scripts/check-dsh-compatibility.mjs (L54)

The Cordis version for the 0.2.2-rc.1 fixture is copied verbatim from the host's peer range (e.g. ~4.1.0). Two problems: (1) nothing asserts that this host-required range is still satisfied by the plugin's own declared peer @deepseek-ai/cordis (^4.0.1 in package.json), so a future host that requires e.g. cordis 5.x would make the matrix pass while real consumer installs hit an unsatisfied-peer warning/ERESOLVE; (2) unlike every dsh package above (pinned to the exact version), a floating range makes the fixture non-reproducible — it silently moves to newer Cordis releases over time. Consider resolving the concrete Cordis version and asserting it against the manifest peer range, e.g.:

const cordisPeer = manifest.peerDependencies["@deepseek-ai/cordis"];
const hostCordis = pkg.peerDependencies?.["@deepseek-ai/cordis"];
// fail loudly instead of silently installing an unmatched Cordis
if (hostCordis && !semver.subset(hostCordis, cordisPeer)) {
  throw new Error(`Plugin peer ${cordisPeer} does not satisfy host-required Cordis ${hostCordis}`);
}
devDependencies["@deepseek-ai/cordis"] = hostCordis;

Generated by cloud-assistant via Open Code Review.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

⚠️ Automated Test Results: ENV ISSUE

The test environment encountered an issue that requires manual attention.

Details: Executor error: Node dependency preparation failed for memos_local_plugin: Command failed with exit code 1: npm ci --include=dev --no-audit --no-fund
stdout:
stderr: npm warn deprecated boolean@3.2.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm error code 1
npm error path /data/test-workspaces/56c8ed87c6d3d96f/repo/apps/memos-local-plugin/node_modules/onnxruntime-node
npm error command failed
npm error command sh -c node ./script/install
npm error /data/test-workspaces/56c8ed87c6d3d96f/repo/apps/memos-local-plugin/node_modules/onnxruntime-node/script/install-utils.js:57
npm error reject(new Error(Failed to download build list. HTTP status code = ${statusCode}));
npm error ^
npm error
npm error Error: Failed to download build list. HTTP status code = 302
npm error at ClientRequest. (/data/test-workspaces/56c8ed87c6d3d96f/repo/apps/memos-local-plugin/node_modules/onnxruntime-node/script/install-utils.js:57:18)
npm error at Object.onceWrapper (node:events:634:26)
npm error at ClientRequest.emit (node:events:519:28)
npm error at ClientRequest.emit (node:domain:489:12)
npm error at HTTPParser.parserOnIncomingClient (node:_http_client:780:27)
npm error at HTTPParser.parserOnHeadersComplete (node:_http_common:125:17)
npm error at TLSSocket.socketOnData (node:_http_client:615:22)
npm error at TLSSocket.emit (node:events:519:28)
npm error at TLSSocket.emit (node:domain:489:12)
npm error at addChunk (node:internal/streams/readable:561:12)
npm error
npm error Node.js v22.22.2
npm error A complete log of this run can be found in: /data/test-workspaces/_shared/npm-downloads/_logs/2026-11-11T05_41_16_776Z-debug-0.log
Branch: feat/dsh-0.2.2-rc1-compat

Tested source: b71d9b45128fec2ca50ef66ba9c33368f497cb42
Tested base: 3a16e5fe3048a209f722806f4123fa2e533588fd
Tested commit: b71d9b45128fec2ca50ef66ba9c33368f497cb42
These results apply only to this immutable source/base snapshot.

@Memtensor-AI Memtensor-AI added status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发 and removed status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:plugin OpenClaw & Hermes status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants